linux-kernel - Re: [PATCH] ALSA: hda: cs35l41: fix building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bka2bsie.wl-tiwai@suse.de>
Date: Wed, 03 Jan 2024 11:50:17 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: James Schulman <james.schulman@...rus.com>,
	David Rhodes <david.rhodes@...rus.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Stefan Binding <sbinding@...nsource.cirrus.com>,
	Arnd Bergmann <arnd@...db.de>,
	Dorian Cruveiller <doriancruveiller@...il.com>,
	Yang Yingliang <yangyingliang@...wei.com>,
	alsa-devel@...a-project.org,
	patches@...nsource.cirrus.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: cs35l41: fix building without CONFIG_SPI

On Wed, 03 Jan 2024 11:25:59 +0100,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> When CONFIG_SPI is disabled, the driver produces unused-variable warning:
> 
> sound/pci/hda/cs35l41_hda_property.c: In function 'generic_dsd_config':
> sound/pci/hda/cs35l41_hda_property.c:181:28: error: unused variable 'spi' [-Werror=unused-variable]
>   181 |         struct spi_device *spi;
>       |                            ^~~
> sound/pci/hda/cs35l41_hda_property.c:180:27: error: unused variable 'cs_gpiod' [-Werror=unused-variable]
>   180 |         struct gpio_desc *cs_gpiod;
>       |                           ^~~~~~~~
> 
> Avoid these by turning the preprocessor contionals into equivalent C code,
> which also helps readability.
> 
> Fixes: 916d051730ae ("ALSA: hda: cs35l41: Only add SPI CS GPIO if SPI is enabled in kernel")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied now.  Thanks.


Takashi