linux-kernel - Re: [PATCH] list: Add hlist_count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Jan 2024 12:25:51 +0100
From: Marco Elver <elver@...gle.com>
To: Pierre Gondois <pierre.gondois@....com>
Cc: linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>, 
	Lucas De Marchi <lucas.demarchi@...el.com>, Jani Nikula <jani.nikula@...el.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] list: Add hlist_count_nodes()

On Wed, 3 Jan 2024 at 10:02, Pierre Gondois <pierre.gondois@....com> wrote:
>
> Add a function to count nodes in a hlist. hlist_count_nodes()
> is similar to list_count_nodes().
>
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>

Is this patch part of another patch series? As-is, this will be dead
code, and there's no guarantee someone will just go and delete it in
future. Although this function looks useful, we also should avoid
adding new dead code.

> ---
>  include/linux/list.h | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/include/linux/list.h b/include/linux/list.h
> index 1837caedf723..0f1b1d4a2e2e 100644
> --- a/include/linux/list.h
> +++ b/include/linux/list.h
> @@ -1175,4 +1175,19 @@ static inline void hlist_move_list(struct hlist_head *old,
>              pos && ({ n = pos->member.next; 1; });                     \
>              pos = hlist_entry_safe(n, typeof(*pos), member))
>
> +/**
> + * hlist_count_nodes - count nodes in the hlist
> + * @head:      the head for your hlist.
> + */
> +static inline size_t hlist_count_nodes(struct hlist_head *head)
> +{
> +       struct hlist_node *pos;
> +       size_t count = 0;
> +
> +       hlist_for_each(pos, head)
> +               count++;
> +
> +       return count;
> +}
> +
>  #endif
> --
> 2.25.1
>