linux-kernel - Re: [PATCH V2 2/4] gpio: sprd: Clear interrupt after set the interrupt type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB9BWhfa=DZcNibjMCNKLxjbBWnO9qus8+H-AwwX2epjKjDn=w@mail.gmail.com>
Date: Wed, 3 Jan 2024 20:06:18 +0800
From: wenhua lin <wenhua.lin1994@...il.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: Wenhua Lin <Wenhua.Lin@...soc.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Orson Zhai <orsonzhai@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH V2 2/4] gpio: sprd: Clear interrupt after set the
 interrupt type

On Thu, Sep 21, 2023 at 7:24 PM Andy Shevchenko <andy@...nel.org> wrote:
>
> On Thu, Sep 21, 2023 at 05:00:25PM +0800, Wenhua Lin wrote:
> > The initialization state of the EIC module is a high level trigger.
>
> Here you use EIC, in other places eic. Can you, please, be consistent?

Thank you very much for your review.
I will fix this issue in patch v3.

>
> > If it is currently a high level, the interrupt condition is met at
> > this time, and the EIC interrupt has a latch capability, which will
> > cause an interrupt to occur after booting. To avoid this, When setting
> > the EIC interrupt trigger type, clear the interrupt once.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>