linux-kernel - Re: [PATCH v2] pwm: bcm2835: Remove duplicate call to clk_rate_exclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <sbcslehlbdhjggyb4thughrzuzjrbc3knbh3ulfhhi6mcrvayd@rbheyjouom6d>
Date: Wed, 3 Jan 2024 13:28:25 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Sean Young <sean@...s.org>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, linux-pwm@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pwm: bcm2835: Remove duplicate call to
 clk_rate_exclusive_put()

Hello Thierry,

On Fri, Dec 22, 2023 at 01:13:11PM +0000, Sean Young wrote:
> devm_add_action_or_reset() already calls the action in the error case.
> 
> Reported-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Closes: https://lore.kernel.org/linux-pwm/fuku3b5ur6y4k4refd3vmeoenzjo6mwe3b3gtel34rhhhtvnsa@w4uktgbqsc3w/
> Fixes: fcc760729359 ("pwm: bcm2835: Allow PWM driver to be used in atomic context")
> Signed-off-by: Sean Young <sean@...s.org>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/pwm/pwm-bcm2835.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c
> index 307c0bd5f885..283cf27f25ba 100644
> --- a/drivers/pwm/pwm-bcm2835.c
> +++ b/drivers/pwm/pwm-bcm2835.c
> @@ -160,10 +160,8 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
>  
>  	ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
>  				       pc->clk);
> -	if (ret) {
> -		clk_rate_exclusive_put(pc->clk);
> +	if (ret)
>  		return ret;
> -	}
>  
>  	pc->rate = clk_get_rate(pc->clk);
>  	if (!pc->rate)

this patch should be added to your for-next branch and then your PR for
the next merge window.

Also "pwm: linux/pwm.h: fix Excess kernel-doc description warning"
(Message-Id: 20231223050621.13994-1-rdunlap@...radead.org) should be
added IMHO.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)