linux-kernel - Re: [PATCH v2 0/4] thermal: intel: hfi: Fix memory corruption on resume from hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hDSgn5Cc_md0ZzCtriA21NcBf6WN49PgtVs1dgUSVsiw@mail.gmail.com>
Date: Wed, 3 Jan 2024 14:15:12 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Chen Yu <yu.c.chen@...el.com>, 
	Len Brown <len.brown@...el.com>, 
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
	Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>, Zhang Rui <rui.zhang@...el.com>, 
	Zhao Liu <zhao1.liu@...el.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] thermal: intel: hfi: Fix memory corruption on
 resume from hibernation

On Wed, Jan 3, 2024 at 5:13 AM Ricardo Neri
<ricardo.neri-calderon@...ux.intel.com> wrote:
>
> Hi,
>
> This is v2 of this series. You can read the overview and motivation in the
> cover letter of v1 [1].
>
> I smoke-retested this version on a Meteor Lake system. It completed 50
> cycles of suspend-to-disk and resume. I completed longer testing for v1.
>
> Changes since v1:
>  * Added locking to hfi_pm_notify() to serialize RMW operations on the
>    MSR_IA32_HW_FEEDBACK_CONFIG register. (Rafael)
>  * Relocated a comment regarding the reallocation of HFI memory to
>    patch 3/4. (Rafael)
>  * Clarified that patch 1/4 does not introduce functional changes.
>    (Rafael)
>  * Indicated the first stable version on which this patchset should be
>    backported.
>  * Renamed hfi_do_pm_[enable|disable]() as hfi_do_[enable|disable]() for
>    future reuse. (Stan)
>  * Registered the HFI suspend notifier towards the end of
>    intel_hfi_init(). (Stan)
>
> Thanks and BR,
> Ricardo
>
> [1]. https://lore.kernel.org/all/20231227062940.10780-1-ricardo.neri-calderon@linux.intel.com/
>
> Ricardo Neri (4):
>   thermal: intel: hfi: Refactor enabling code into helper functions
>   thermal: intel: hfi: Enable an HFI instance from its first online CPU
>   thermal: intel: hfi: Disable an HFI instance when all its CPUs go
>     offline
>   thermal: intel: hfi: Add a suspend notifier
>
>  drivers/thermal/intel/intel_hfi.c | 153 +++++++++++++++++++++++++-----
>  1 file changed, 127 insertions(+), 26 deletions(-)
>
> --

I've queued up the first 3 patches from the series for 6.8 as they
make sense even without the [4/4] IMO.

I still have some comments on the last one, though, but let me reply
to it directly.