linux-kernel - Re: [PATCH v2] staging: rtl8712: fix open parentheses alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 3 Jan 2024 14:32:53 +0100
From: Nam Cao <namcao@...utronix.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Ryan England <rcengland@...il.com>, Larry Finger
 <Larry.Finger@...inger.net>, Florian Schilhabel
 <florian.c.schilhabel@...glemail.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH v2] staging: rtl8712: fix open parentheses alignment

On Wed, 3 Jan 2024 16:19:45 +0300 Dan Carpenter <dan.carpenter@...aro.org> wrote:
> On Fri, Dec 22, 2023 at 09:47:35AM +0100, Nam Cao wrote:
> > On Thu, 21 Dec 2023 20:22:48 +0000 Ryan England <rcengland@...il.com> wrote:
> > >  static u32 start_drv_threads(struct _adapter *padapter)
> > >  {
> > > -	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s",
> > > -					  padapter->pnetdev->name);
> > > +	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s", padapter->pnetdev->name);  
> > 
> > Your description claims to fix "CHECK: Alignment should match open
> > parenthesis", but this one is already aligned, isn't it?  
> 
> No.  It was not aligned.  There was a space character missing.

Ah right, sorry for the noises.

Best regards,
Nam