linux-kernel - Re: [PATCH] tpm: cr50: fix kernel-doc warning and spelling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 03 Jan 2024 15:43:19 +0200
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Randy Dunlap" <rdunlap@...radead.org>, <linux-kernel@...r.kernel.org>
Cc: "Peter Huewe" <peterhuewe@....de>, "Jason Gunthorpe" <jgg@...pe.ca>,
 <linux-integrity@...r.kernel.org>
Subject: Re: [PATCH] tpm: cr50: fix kernel-doc warning and spelling

On Fri Dec 22, 2023 at 8:19 AM EET, Randy Dunlap wrote:
> Fix kernel-doc notation to prevent a warning:
> tpm_tis_i2c_cr50.c:681: warning: Excess function parameter 'id' description in 'tpm_cr50_i2c_probe'
>
> and fix a spelling error reported by codespell.
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Peter Huewe <peterhuewe@....de>
> Cc: Jarkko Sakkinen <jarkko@...nel.org>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: linux-integrity@...r.kernel.org
> ---
>  drivers/char/tpm/tpm_tis_i2c_cr50.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -- a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -235,7 +235,7 @@ out:
>   * @len:	Number of bytes to write.
>   *
>   * The provided address is prepended to the data in 'buffer', the
> - * cobined address+data is sent to the TPM, then wait for TPM to
> + * combined address+data is sent to the TPM, then wait for TPM to
>   * indicate it is done writing.
>   *
>   * Return:
> @@ -671,7 +671,6 @@ MODULE_DEVICE_TABLE(of, of_cr50_i2c_matc
>  /**
>   * tpm_cr50_i2c_probe() - Driver probe function.
>   * @client:	I2C client information.
> - * @id:		I2C device id.
>   *
>   * Return:
>   * - 0:		Success.


Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...nel.org>

BR, Jarkko