linux-kernel - Re: [PATCH v2] xprtrdma: removed asm-generic headers from verbs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZZVySJF2rXI/qJQx@tissot.1015granger.net>
Date: Wed, 3 Jan 2024 09:42:16 -0500
From: Chuck Lever <chuck.lever@...cle.com>
To: Tanzir Hasan <tanzirh@...gle.com>
Cc: Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>,
        Olga Kornievskaia <kolga@...app.com>, Dai Ngo <dai.ngo@...cle.com>,
        Tom Talpey <tom@...pey.com>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Nick Desaulniers <nnn@...gle.com>, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v2] xprtrdma: removed asm-generic headers from verbs.c

On Tue, Jan 02, 2024 at 05:22:18PM -0500, Tanzir Hasan wrote:
> asm-generic/barrier.h and asm/bitops.h are already brought into the
> file through the header linux/sunrpc/svc_rdma.h and the file can
> still be built with their removal. They have been replaced with the
> preferred linux/bitops.h and asm/barrier.h to remove the need for the
> asm-generic header.
> 
> Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@...gle.com>

Acked-by: Chuck Lever <chuck.lever@...cle.com>


> ---
> Changes in v2:
> - Added asm/barrier.h and linux/bitops.h to not conflict with rule 1 of
>   submit-checklist
> - Link to v1: https://lore.kernel.org/r/20231226-verbs-v1-1-3a2cecf11afd@google.com
> ---
>  net/sunrpc/xprtrdma/verbs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index 28c0771c4e8c..b4c1d874fc7e 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -49,14 +49,14 @@
>   *  o buffer memory
>   */
>  
> +#include <linux/bitops.h>
>  #include <linux/interrupt.h>
>  #include <linux/slab.h>
>  #include <linux/sunrpc/addr.h>
>  #include <linux/sunrpc/svc_rdma.h>
>  #include <linux/log2.h>
>  
> -#include <asm-generic/barrier.h>
> -#include <asm/bitops.h>
> +#include <asm/barrier.h>
>  
>  #include <rdma/ib_cm.h>
>  
> 
> ---
> base-commit: fbafc3e621c3f4ded43720fdb1d6ce1728ec664e
> change-id: 20231226-verbs-30800631d3f1
> 
> Best regards,
> -- 
> Tanzir Hasan <tanzirh@...gle.com>
> 

-- 
Chuck Lever