[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240103155811.4092035-1-arnd@kernel.org>
Date: Wed, 3 Jan 2024 16:58:05 +0100
From: Arnd Bergmann <arnd@...nel.org>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Paul Elder <paul.elder@...asonboard.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Arnd Bergmann <arnd@...db.de>,
Hans de Goede <hdegoede@...hat.com>,
Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
Alain Volmat <alain.volmat@...s.st.com>,
Mehdi Djait <mehdi.djait@...tlin.com>,
linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] media: i2c: thp7312: select CONFIG_FW_LOADER
From: Arnd Bergmann <arnd@...db.de>
The recently added driver uses the firmware loader mechanism but causes
a link failure when that is in a loadable module while thp7312 itself
is built-in:
arm-linux-gnueabi-ld: drivers/media/i2c/thp7312.o: in function `thp7312_probe':
thp7312.c:(.text+0x4164): undefined reference to `firmware_upload_register'
Select the required Kconfig symbol. Note that the driver specifically
needs the firmware upload interface that is controlled by CONFIG_FW_UPLOAD,
but there is no link failure when that is disabled because the interfaces
are stubbed out here.
Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 78a87331686e..4c3435921f19 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -674,6 +674,7 @@ menu "Camera ISPs"
config VIDEO_THP7312
tristate "THine THP7312 support"
depends on I2C
+ select FW_LOADER
select MEDIA_CONTROLLER
select V4L2_CCI_I2C
select V4L2_FWNODE
--
2.39.2
Powered by blists - more mailing lists