linux-kernel - Re: [PATCH v5 2/2] arm64: dts: imx93-var-som: Add Variscite VAR-SOM-MX93

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c23ca102-f80d-45f7-96a2-857a567f1d5c@linaro.org>
Date: Wed, 3 Jan 2024 17:24:32 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Mathieu Othacehe <othacehe@....org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>,
 Li Yang <leoyang.li@....com>, Stefan Wahren <wahrenst@....net>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 2/2] arm64: dts: imx93-var-som: Add Variscite
 VAR-SOM-MX93

On 03/01/2024 15:36, Mathieu Othacehe wrote:
> Add DTSI for Variscite VAR-SOM-MX93 System on Module and DTS for Variscite
> VAR-SOM-MX93 on Symphony evaluation board.
> 
> This version comes with:
> - NXP i.MX 93 Dual, 1.7GHz, Cortex-A55 + Cortex-M33
> - 2 GB of RAM
> - 16GB eMMC
> - 802.11ax/ac/a/b/g/n WiFi with 5.3 Bluetooth
> - CAN bus
> - Audio codec
> 
> Reviewed-by: Fabio Estevam <festevam@...il.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

You made significant changes, which invalidates both reviews. What's
more, you did not test the changes after adding them.

You must drop the tags after introducing such changes.

> +
> +		key-menu {
> +			label = "Menu";
> +			gpios = <&pca9534 3 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_MENU>;
> +		};
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		status = "okay";

???

> +
> +		heartbeat {

This wasn't here during my review

> +			label = "Heartbeat";
> +			gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).


Best regards,
Krzysztof