lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZZWPuIjp0xklrcGy@kernel.org>
Date: Wed, 3 Jan 2024 13:47:52 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: "Liang, Kan" <kan.liang@...ux.intel.com>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	John Garry <john.g.garry@...cle.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Guillaume Endignoux <guillaumee@...gle.com>
Subject: Re: [PATCH v1] perf stat: Fix hard coded ll miss units

Em Tue, Jan 02, 2024 at 03:01:55PM -0500, Liang, Kan escreveu:
> 
> 
> On 2024-01-02 2:34 p.m., Ian Rogers wrote:
> > On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@...gle.com> wrote:
> >>
> >> Copy-paste error where LL cache misses are reported as l1i.
> >>
> >> Suggested-by: Guillaume Endignoux <guillaumee@...gle.com>
> >> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
> >> Signed-off-by: Ian Rogers <irogers@...gle.com>
> >
> 
> Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks, applied to perf-tools-next.

- Arnaldo

 
> Thanks,
> Kan
> 
> > Ping. Trivial 1 character fix but no reviews :-(
> > 
> > Thanks,
> > Ian
> > 
> >> ---
> >>  tools/perf/util/stat-shadow.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> >> index 1c5c3eeba4cf..e31426167852 100644
> >> --- a/tools/perf/util/stat-shadow.c
> >> +++ b/tools/perf/util/stat-shadow.c
> >> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
> >>         static const double color_ratios[3] = {20.0, 10.0, 5.0};
> >>
> >>         print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
> >> -                   "of all L1-icache accesses");
> >> +                   "of all LL-cache accesses");
> >>  }
> >>
> >>  static void print_dtlb_miss(struct perf_stat_config *config,
> >> --
> >> 2.43.0.472.g3155946c3a-goog
> >>
> > 

-- 

- Arnaldo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ