[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZZWShvM4Fcs3Oogk@shell.armlinux.org.uk>
Date: Wed, 3 Jan 2024 16:59:50 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
William Zhang <william.zhang@...adcom.com>,
Anand Gore <anand.gore@...adcom.com>,
Kursad Oney <kursad.oney@...adcom.com>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Rafał Miłecki <rafal@...ecki.pl>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Jacek Anaszewski <jacek.anaszewski@...il.com>,
Fernández Rojas <noltari@...il.com>,
Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
netdev@...r.kernel.org
Subject: Re: [net-next PATCH v6 5/5] net: phy: at803x: add LED support for
qca808x
On Tue, Jan 02, 2024 at 07:38:34PM +0100, Christian Marangi wrote:
> + if (active_low) {
> + ret = phy_clear_bits_mmd(phydev, MDIO_MMD_AN,
> + QCA808X_MMD7_LED_POLARITY_CTRL,
> + QCA808X_LED_ACTIVE_HIGH);
> + } else {
> + ret = phy_set_bits_mmd(phydev, MDIO_MMD_AN,
> + QCA808X_MMD7_LED_POLARITY_CTRL,
> + QCA808X_LED_ACTIVE_HIGH);
> + }
Maybe:
return phy_modify_mmd(phydev, MDIO_MMD_AN,
QCA808X_MMD7_LED_POLARITY_CTRL,
active_low ? 0 : QCA808X_LED_ACTIVE_HIGH);
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists