linux-kernel - Re: [PATCH v1] perf env: Avoid recursively taking env->bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW6EZ-FoZFbCuxs7gAa0OaQGw0zMLDaeEsNoU31vjXijnQ@mail.gmail.com>
Date: Wed, 3 Jan 2024 09:40:26 -0800
From: Song Liu <song@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>, 
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Namhyung Kim <namhyung@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
	Ming Wang <wangming01@...ngson.cn>, Ravi Bangoria <ravi.bangoria@....com>, 
	Huacai Chen <chenhuacai@...nel.org>, Kan Liang <kan.liang@...ux.intel.com>, 
	K Prateek Nayak <kprateek.nayak@....com>, linux-perf-users@...r.kernel.org, 
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v1] perf env: Avoid recursively taking env->bpf_progs.lock

On Wed, Jan 3, 2024 at 8:27 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> Em Tue, Jan 02, 2024 at 07:00:53PM -0800, Ian Rogers escreveu:
> > On Wed, Dec 6, 2023 at 5:46 PM Ian Rogers <irogers@...gle.com> wrote:
> > >
> > > Add variants of perf_env__insert_bpf_prog_info, perf_env__insert_btf
> > > and perf_env__find_btf prefixed with __ to indicate the
> > > env->bpf_progs.lock is assumed held. Call these variants when the lock
> > > is held to avoid recursively taking it and potentially having a thread
> > > deadlock with itself.
> > >
> > > Signed-off-by: Ian Rogers <irogers@...gle.com>
> >
> > Ping.
>
> Applied, with that minor patch reduction hunk and this:
>
> Fixes: f8dfeae009effc0b ("perf bpf: Show more BPF program info in print_bpf_prog_info()")
>
> Song, can I have your Acked-by?

LGTM. Thanks for the fix!

Acked-by: Song Liu <song@...nel.org>