linux-kernel - Prototype patch to avoid TREE07 rcu_torture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a40344c8-a260-41f3-bd7a-6a63d8660489@paulmck-laptop>
Date: Wed, 3 Jan 2024 11:29:47 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Frederic Weisbecker <frederic@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Prototype patch to avoid TREE07 rcu_torture_writer() stalls

Hello, Frederic,

You mentioned rcu_torture_writer() stall issues on TREE07.  Does the
patch shown below help?

If so, I predict that your bisection will converge on commit af19a2526cba9
("rcutorture: Add mid-sized stall to TREE07").

							Thanx, Paul

------------------------------------------------------------------------

commit 7e9794bb7017593da427f555e4e23da2d42744e5
Author: Paul E. McKenney <paulmck@...nel.org>
Date:   Wed Jan 3 10:59:25 2024 -0800

    rcutorture: Suppress rtort_pipe_count warnings until after stalls
    
    Currently, if rcu_torture_writer() sees fewer than ten grace periods
    having elapsed during a call to stutter_wait() that actually waited,
    the rtort_pipe_count warning is emitted.  This has worked well for
    a long time.  Except that the rcutorture TREE07 scenario now does a
    short-term 14-second RCU CPU stall, which can most definitely case
    false-positive rtort_pipe_count warnings.
    
    This commit therefore changes rcu_torture_writer() to compute the
    full expected holdoff and stall duration, and to refuse to report any
    rtort_pipe_count warnings until after all stalls have completed.
    
    Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
    Cc: Frederic Weisbecker <frederic@...nel.org>

diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 50ac86a34876..b4317ef1b092 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1372,9 +1372,13 @@ rcu_torture_writer(void *arg)
 	struct rcu_torture *rp;
 	struct rcu_torture *old_rp;
 	static DEFINE_TORTURE_RANDOM(rand);
+	unsigned long stallsdone = jiffies;
 	bool stutter_waited;
 	unsigned long ulo[NUM_ACTIVE_RCU_POLL_OLDSTATE];
 
+	// If a new stall test is added, this must be adjusted.
+	if (stall_cpu_holdoff + stall_gp_kthread + stall_cpu)
+		stallsdone += (stall_cpu_holdoff + stall_gp_kthread + stall_cpu + 60) * HZ;
 	VERBOSE_TOROUT_STRING("rcu_torture_writer task started");
 	if (!can_expedite)
 		pr_alert("%s" TORTURE_FLAG
@@ -1580,11 +1584,11 @@ rcu_torture_writer(void *arg)
 		    !atomic_read(&rcu_fwd_cb_nodelay) &&
 		    !cur_ops->slow_gps &&
 		    !torture_must_stop() &&
-		    boot_ended)
+		    boot_ended &&
+		    time_after(jiffies, stallsdone))
 			for (i = 0; i < ARRAY_SIZE(rcu_tortures); i++)
 				if (list_empty(&rcu_tortures[i].rtort_free) &&
-				    rcu_access_pointer(rcu_torture_current) !=
-				    &rcu_tortures[i]) {
+				    rcu_access_pointer(rcu_torture_current) != &rcu_tortures[i]) {
 					tracing_off();
 					show_rcu_gp_kthreads();
 					WARN(1, "%s: rtort_pipe_count: %d\n", __func__, rcu_tortures[i].rtort_pipe_count);
@@ -2445,7 +2449,8 @@ static struct notifier_block rcu_torture_stall_block = {
 
 /*
  * CPU-stall kthread.  It waits as specified by stall_cpu_holdoff, then
- * induces a CPU stall for the time specified by stall_cpu.
+ * induces a CPU stall for the time specified by stall_cpu.  If a new
+ * stall test is added, stallsdone in rcu_torture_writer() must be adjusted.
  */
 static int rcu_torture_stall(void *args)
 {