linux-kernel - Re: [PATCH] Bluetooth: hci_sync: Check the correct flag before starting a scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170440682635.8457.5875385181619423548.git-patchwork-notify@kernel.org>
Date: Thu, 04 Jan 2024 22:20:26 +0000
From: patchwork-bot+bluetooth@...nel.org
To: Jonas Dreßler <verdre@...d.nl>@codeaurora.org
Cc: marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
 linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_sync: Check the correct flag before starting a
 scan

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@...el.com>:

On Tue,  2 Jan 2024 19:08:08 +0100 you wrote:
> There's a very confusing mistake in the code starting a HCI inquiry: We're
> calling hci_dev_test_flag() to test for HCI_INQUIRY, but hci_dev_test_flag()
> checks hdev->dev_flags instead of hdev->flags. HCI_INQUIRY is a bit that's
> set on hdev->flags, not on hdev->dev_flags though.
> 
> HCI_INQUIRY equals the integer 7, and in hdev->dev_flags, 7 means
> HCI_BONDABLE, so we were actually checking for HCI_BONDABLE here.
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_sync: Check the correct flag before starting a scan
    https://git.kernel.org/bluetooth/bluetooth-next/c/626cef40faf0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html