linux-kernel - RE: [PATCH v2] media: venus: use div64_u64() instead of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2baa3220f0e4f64b402f549f13b0671@AcuMS.aculab.com>
Date: Thu, 4 Jan 2024 23:14:15 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Himanshu Bhavani' <himanshu.bhavani@...iconsignals.io>,
	"stanimir.k.varbanov@...il.com" <stanimir.k.varbanov@...il.com>,
	"quic_vgarodia@...cinc.com" <quic_vgarodia@...cinc.com>, "agross@...nel.org"
	<agross@...nel.org>, "andersson@...nel.org" <andersson@...nel.org>,
	"konrad.dybcio@...aro.org" <konrad.dybcio@...aro.org>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "quic_dikshita@...cinc.com" <quic_dikshita@...cinc.com>
CC: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] media: venus: use div64_u64() instead of do_div()

From: Himanshu Bhavani
> Sent: 02 January 2024 13:15
> 
> do_div() does a 64-by-32 division.
> When the divisor is u64, do_div() truncates it to 32 bits,
> this means it can test non-zero and be truncated to zero for
> division.
> 
> fix do_div.cocci warning:
> do_div() does a 64-by-32 division, please consider using div64_u64
> instead.

That message is really wrong, it should ask you to check the domains
of the divisor and dividend to ensure the quotient won't exceed 32bits.

I'm not sure about this code, but it looks like the second do_div()
could just be a divide, it is USEC_PER_SEC/n which is well inside 32bits.
The 'n' is the result of the first divide - so that is small as well.

64-by-64 divides are horribly slow on 32bit.
They are even about twice as slow as 64-by-32 on intel x64-64 chips.

	David

> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> ---
>  drivers/media/platform/qcom/venus/venc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 44b13696cf82..ad6c31c272ac 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -409,13 +409,13 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
>  	out->capability = V4L2_CAP_TIMEPERFRAME;
> 
>  	us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC;
> -	do_div(us_per_frame, timeperframe->denominator);
> +	us_per_frame = div64_u64(us_per_frame, timeperframe->denominator);
> 
>  	if (!us_per_frame)
>  		return -EINVAL;
> 
>  	fps = (u64)USEC_PER_SEC;
> -	do_div(fps, us_per_frame);
> +	fps = div64_u64(fps, us_per_frame);
> 
>  	inst->timeperframe = *timeperframe;
>  	inst->fps = fps;
> --
> 2.25.1
> 

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)