linux-kernel - Re: [PATCH net] netfilter: nf_nat: fix action not being set for all ct states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240104050452.808076-1-brad@faucet.nz>
Date: Thu,  4 Jan 2024 18:04:52 +1300
From: Brad Cowie <brad@...cet.nz>
To: aconole@...hat.com
Cc: brad@...cet.nz, coreteam@...filter.org, davem@...emloft.net,
 dev@...nvswitch.org, edumazet@...gle.com, fw@...len.de, horms@...nel.org,
 kadlec@...filter.org, kuba@...nel.org, linux-kernel@...r.kernel.org,
 lucien.xin@...il.com, netdev@...r.kernel.org,
 netfilter-devel@...r.kernel.org, pabeni@...hat.com, pablo@...filter.org
Subject: Re: [PATCH net] netfilter: nf_nat: fix action not being set for all ct states

On Wed, 3 Jan 2024 at 04:10, Aaron Conole <aconole@...hat.com> wrote:

> LGTM.  I guess we should try to codify the specific flows that were used
> to flag this into the ovs selftest - we clearly have a missing case
> after NAT lookup.

Thanks for the review Aaron, and the sensible suggestion to add a
test to ovs to avoid this problem occuring again in future.

I've simplified our NAT ruleset and turned it into an ovs system test,
which I've submitted as a patch [1] to ovs-dev. The test reproduces
the issue introduced by ebddb1404900 and passes when e6345d2824a3
is applied.

[1]: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410476.html