linux-kernel - Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e571d57804562a86b07e8aadf2e43c7439b3a78b.camel@mediatek.com>
Date: Thu, 4 Jan 2024 06:14:48 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: Mac Shen (沈俊) <Mac.Shen@...iatek.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	Jitao Shi (石记涛) <jitao.shi@...iatek.com>,
	"daniel@...ll.ch" <daniel@...ll.ch>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "airlied@...il.com" <airlied@...il.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	Shuijing Li (李水静) <Shuijing.Li@...iatek.com>
Subject: Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
> 
> Signed-off-by: mac.shen <mac.shen@...iatek.com>
> ---

[snip]

> +
> +void mdrv_dp_tx_hdcp1x_set_start_auth(struct mtk_hdcp_info
> *hdcp_info, bool enable)

The prefix 'mdrv' of each function seems redundant. So drop the prifix
'mdrv'.

Regards,
CK

> +{
> +	hdcp_info->hdcp1x_info.enable = enable;
> +
> +	if (enable) {
> +		hdcp_info->auth_status = AUTH_INIT;
> +		hdcp_info->hdcp1x_info.main_states =
> HDCP1X_main_state_A0;
> +		hdcp_info->hdcp1x_info.sub_states =
> HDCP1X_sub_FSM_IDLE;
> +	} else {
> +		hdcp_info->auth_status = AUTH_ZERO;
> +		hdcp_info->hdcp1x_info.main_states =
> HDCP1X_main_state_H2;
> +		hdcp_info->hdcp1x_info.sub_states =
> HDCP1X_sub_FSM_IDLE;
> +		tee_hdcp_enable_encrypt(hdcp_info, false, HDCP_NONE);
> +		mhal_dp_tx_hdcp1x_start_cipher(hdcp_info, false);
> +		tee_hdcp1x_soft_rst(hdcp_info);
> +	}
> +
> +	hdcp_info->hdcp1x_info.retry_count = 0;
> +}
> +