linux-kernel - Re: [Intel-wired-lan] [RFC PATCH v3 11/11] ABI: pps: Add ABI documentation for Intel TIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8dcef7e-3659-4af4-b391-169081343fba@molgen.mpg.de>
Date: Thu, 4 Jan 2024 01:24:36 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: lakshmi.sowjanya.d@...el.com
Cc: tglx@...utronix.de, jstultz@...gle.com, giometti@...eenne.com,
 corbet@....net, linux-kernel@...r.kernel.org, christopher.s.hall@...el.com,
 linux-doc@...r.kernel.org, netdev@...r.kernel.org, pandith.n@...el.com,
 x86@...nel.org, eddie.dong@...el.com, jesse.brandeburg@...el.com,
 linux-sound@...r.kernel.org, alexandre.torgue@...s.st.com,
 mallikarjunappa.sangannavar@...el.com, joabreu@...opsys.com,
 intel-wired-lan@...ts.osuosl.org, mcoquelin.stm32@...il.com,
 thejesh.reddy.t.r@...el.com, perex@...ex.cz, anthony.l.nguyen@...el.com,
 andriy.shevchenko@...ux.intel.com, davem@...emloft.net
Subject: Re: [Intel-wired-lan] [RFC PATCH v3 11/11] ABI: pps: Add ABI
 documentation for Intel TIO

Dear Lakshmi,


Thank you for your patch.

Am 03.01.24 um 12:56 schrieb lakshmi.sowjanya.d@...el.com:
> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
> 
> Document sysfs interface for Intel Timed I/O PPS driver

I’d add a dot/period at the end.

> Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
> ---
>   Documentation/ABI/testing/sysfs-platform-pps-tio | 7 +++++++
>   1 file changed, 7 insertions(+)
>   create mode 100644 Documentation/ABI/testing/sysfs-platform-pps-tio
> 
> diff --git a/Documentation/ABI/testing/sysfs-platform-pps-tio b/Documentation/ABI/testing/sysfs-platform-pps-tio
> new file mode 100644
> index 000000000000..24a2eb591a05
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-platform-pps-tio
> @@ -0,0 +1,7 @@
> +What:		/sys/devices/platform/INTCxxxx/enable
> +Date:		March 2024
> +KernelVersion	6.9
> +Contact:	Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
> +Description:
> +		(RW) Enable or disable PPS TIO generator output, read to
> +		see the status of hardware(Enabled/Disabled).

Please add a space before the (.

Wouldn’t it be more intuitive, if it returned true/false?


Kind regards,

Paul