linux-kernel - Re: [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR for Sophgo CV1800 series SoC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbc6ebbb-9ec2-48af-b57e-a4dcb531973f@linaro.org>
Date: Thu, 4 Jan 2024 09:37:33 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jingbao Qiu <qiujingbao.dlmu@...il.com>, a.zummo@...ertech.it,
 alexandre.belloni@...tlin.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu
Cc: linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, dlan@...too.org, inochiama@...look.com
Subject: Re: [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR
 for Sophgo CV1800 series SoC.

On 29/12/2023 10:06, Jingbao Qiu wrote:
> Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Subject: Make it concise. It's way over the limit. Also, unnecessary
full stop.

This all applies to all your patches.

> 

> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
> ---

What changed here? Where is the changelog? Did you just ignore entire
feedback from v3?

>  .../bindings/power/sophgo,cv1800-por.yaml     | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> new file mode 100644
> index 000000000000..8706230a1cbc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/sophgo,cv1800-por.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Power-On-Reset/POR of the Sophgo CV1800 SoC
> +
> +maintainers:
> +  - Jingbao Qiu <qiujingbao.dlmu@...il.com>
> +
> +description:
> +  This hardware provides triggering and timing control
> +  for chip power on, off, and reset.
> +
> +properties:
> +  compatible:
> +    const: sophgo,cv1800-por
> +

Empty schema, drop entire file. You do not need it.

Best regards,
Krzysztof