linux-kernel - RE: [PATCH v2 1/2] cdx: call of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM4PR12MB7765E1280F2070228FE9D8BA8F67A@DM4PR12MB7765.namprd12.prod.outlook.com>
Date: Thu, 4 Jan 2024 09:06:34 +0000
From: "Gangurde, Abhijit" <abhijit.gangurde@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: "Gupta, Nipun" <Nipun.Gupta@....com>, "Agarwal, Nikhil"
	<nikhil.agarwal@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] cdx: call of_node_put() on error path

[AMD Official Use Only - General]

> Add a missing call to of_node_put(np) on error.
>
> There was a second error path where "np" was NULL, but that situation is
> impossible.  The for_each_compatible_node() loop iterator is always
> non-NULL.  Just deleted that error path.
>
> Fixes: 54b406e10f03 ("cdx: Remove cdx controller list from cdx bus system")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
Acked-by: Abhijit Gangurde <abhijit.gangurde@....com>

Thanks,
Abhijit