linux-kernel - Re: [RFC PATCH 3/5] dt-bindings: regulator: add documentation entry for 88pm88x-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <596216f2-d6c7-4432-938f-e73a969ec2da@linaro.org>
Date: Thu, 4 Jan 2024 10:26:10 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Karel Balej <karelb@...li.ms.mff.cuni.cz>, Karel Balej
 <balejk@...fyz.cz>, Lee Jones <lee@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Duje Mihanović <duje.mihanovic@...le.hr>,
 ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [RFC PATCH 3/5] dt-bindings: regulator: add documentation entry
 for 88pm88x-regulator

On 04/01/2024 10:25, Krzysztof Kozlowski wrote:
> On 28/12/2023 10:39, Karel Balej wrote:
>> From: Karel Balej <balejk@...fyz.cz>
>>
> 
> A nit, subject: drop second/last, redundant "documentation entry". The
> "dt-bindings" prefix is already stating that these are bindings.
> 
>> The Marvell 88PM88X PMICs provide regulators among other things.
>> Document how to use them.
> 
> 
> You did not document them in the bindings. You just added example to
> make it complete. Where is the binding change?
> 
> What's more, I have doubts that you tested it.

I found your other patchset - now I am 100% sure you did not test it.

Best regards,
Krzysztof