linux-kernel - Re: [PATCH 1/3] dt-bindings: clk: sprd: Add UMS9620 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f66cf69-5d2c-4e15-bf44-4b96a4cc2900@linaro.org>
Date: Thu, 4 Jan 2024 10:31:03 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Chunyan Zhang <zhang.lyra@...il.com>
Cc: Chunyan Zhang <chunyan.zhang@...soc.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Orson Zhai <orsonzhai@...il.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>
Subject: Re: [PATCH 1/3] dt-bindings: clk: sprd: Add UMS9620 support

On 04/01/2024 10:26, Chunyan Zhang wrote:
>>>> Missing names.
>>>
>>> The names are fixed, but the order are not.
>>
>> Order must be fixed.

Did you read this? It must be. If it is not, your patchset has issues
you must fix.


>>
>>>
>>> For example:
>>> clk_a {
>>>     clocks = <&ext_26m>, <&ext_32k>;
>>>     clock-names = "ext-26m", "ext-32k";
>>> };
>>>
>>> clk_b {
>>>     clocks = <&ext_26m>, <&ext_4m>;
>>>     clock-names = "ext-26m", "ext-4m";
>>
>> And here the order is fixed...
> 
> The order is not fixed, 'clk_b' will cause dtb_check error, since it
> skips the second one i.e. ext-32k in the clock-names list.

Then why do you use the same compatible for two different devices?

Best regards,
Krzysztof