linux-kernel - Re: [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR for Sophgo CV1800 series SoC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f216b869-6a62-49bc-a32b-8ae7852d2274@linaro.org>
Date: Thu, 4 Jan 2024 11:45:00 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jingbao Qiu <qiujingbao.dlmu@...il.com>
Cc: a.zummo@...ertech.it, alexandre.belloni@...tlin.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
 linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, dlan@...too.org, inochiama@...look.com
Subject: Re: [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR
 for Sophgo CV1800 series SoC.

On 04/01/2024 11:39, Jingbao Qiu wrote:
> On Thu, Jan 4, 2024 at 4:37 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 29/12/2023 10:06, Jingbao Qiu wrote:
>>> Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.
>>
>> Please wrap commit message according to Linux coding style / submission
>> process (neither too early nor over the limit):
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>>
>> Subject: Make it concise. It's way over the limit. Also, unnecessary
>> full stop.
>>
>> This all applies to all your patches.
>>
> 
> I will do that.
> 
>>>
>>
>>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
>>> ---
>>
>> What changed here? Where is the changelog? Did you just ignore entire
>> feedback from v3?
> 
> Actually, I separated the previous patches because there were issues
> in various places.
> I want to solve it bit by bit. Should I continue with the current
> patch changes or return to
> the previous patch?

You need to keep consistent versioning and changelogs.

Best regards,
Krzysztof