linux-kernel - RE: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <BL3PR02MB82343490A93C76C810CD391B88672@BL3PR02MB8234.namprd02.prod.outlook.com>
Date: Thu, 4 Jan 2024 11:41:19 +0000
From: Ritesh Kumar <riteshk@....qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Ritesh Kumar
 (QUIC)" <quic_riteshk@...cinc.com>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
        "Jessica Zhang
 (QUIC)" <quic_jesszhan@...cinc.com>,
        "sam@...nborg.org" <sam@...nborg.org>,
        "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "tzimmermann@...e.de"
	<tzimmermann@...e.de>,
        "airlied@...il.com" <airlied@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "robh+dt@...nel.org"
	<robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org"
	<conor+dt@...nel.org>,
        "Abhinav Kumar (QUIC)" <quic_abhinavk@...cinc.com>,
        "Rajeev Nandan (QUIC)" <quic_rajeevny@...cinc.com>,
        "Vishnuvardhan Prodduturi
 (QUIC)" <quic_vproddut@...cinc.com>,
        "sumit.semwal@...aro.org"
	<sumit.semwal@...aro.org>
Subject: RE: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI
 panel

Hi Krzysztof,

>-----Original Message-----
>From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>Sent: Friday, December 22, 2023 9:02 PM
>To: Ritesh Kumar (QUIC) <quic_riteshk@...cinc.com>; dri-
>devel@...ts.freedesktop.org; devicetree@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Cc: neil.armstrong@...aro.org; Jessica Zhang (QUIC)
><quic_jesszhan@...cinc.com>; sam@...nborg.org;
>maarten.lankhorst@...ux.intel.com; mripard@...nel.org;
>tzimmermann@...e.de; airlied@...il.com; daniel@...ll.ch;
>robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>Abhinav Kumar (QUIC) <quic_abhinavk@...cinc.com>; Rajeev Nandan (QUIC)
><quic_rajeevny@...cinc.com>; Vishnuvardhan Prodduturi (QUIC)
><quic_vproddut@...cinc.com>
>Subject: Re: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI
>panel
>
>WARNING: This email originated from outside of Qualcomm. Please be wary of
>any links or attachments, and do not enable macros.
>
>On 22/12/2023 12:07, Ritesh Kumar wrote:
>> Document Truly NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar <quic_riteshk@...cinc.com>
>> ---
>>  .../display/panel/truly,nt36672e.yaml         | 66 +++++++++++++++++++
>>  1 file changed, 66 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> new file mode 100644
>> index 000000000000..39ab05c5b103
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.y
>> +++ aml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Truly NT36672E LCD DSI Panel
>> +
>> +maintainers:
>> +  - Ritesh Kumar <quic_riteshk@...cinc.com>
>> +
>> +allOf:
>> +  - $ref: panel-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: truly,nt36672e
>
>Eee? This is existing Novatek, isn't it?

This is novatek nt36672e panel. Existing novatek is nt36672a panel.
They differ in resolution, power on/off sequence (init sequence, delays), panel reset sequence.
NT36672E panel supports refresh rates of 60Hz, 90Hz, 120Hz and 144Hz. It also supports DSC.
To start with, I have added support for uncompressed 60Hz. In subsequent patches, other configurations
support will be added.

>
>> +
>> +  reg:
>> +    maxItems: 1
>> +    description: DSI virtual channel
>> +
>> +  vddi-supply: true
>> +  avdd-supply: true
>> +  avee-supply: true
>> +  port: true
>> +  reset-gpios: true
>> +  backlight: true
>> +
>> +additionalProperties: false
>
>
>This goes after required:.

Thanks, will change in next version.

Thanks,
Ritesh