linux-kernel - Re: [PATCH] OPP: Remove the unused argument to config_clks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d994e6c3-f69e-4910-b699-65cb3ab6c72b@kernel.org>
Date: Thu, 4 Jan 2024 13:56:03 +0100
From: Konrad Dybcio <konradybcio@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Bart Van Assche <bvanassche@....org>, Dmitry Osipenko <digetx@...il.com>,
 Thierry Reding <thierry.reding@...il.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
 Viresh Kumar <vireshk@...nel.org>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 "James E.J. Bottomley" <jejb@...ux.ibm.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Alim Akhtar <alim.akhtar@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 MyungJoo Ham <myungjoo.ham@...sung.com>, Nishanth Menon <nm@...com>,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-scsi@...r.kernel.org, linux-tegra@...r.kernel.org,
 Avri Altman <avri.altman@....com>, Bjorn Andersson <andersson@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH] OPP: Remove the unused argument to config_clks_t

On 4.01.2024 13:53, Konrad Dybcio wrote:
> 
> On 3.01.2024 11:48, Viresh Kumar wrote:
>> The OPP core needs to take care of a special case, where the OPPs aren't
>> available for a device, but in order to keep the same unified interface
>> for the driver, the same OPP core API must take care of performing a
>> simple clk_set_rate() for the device.
>>
>> This required the extra argument, but that is used only within the OPP
>> core and the drivers don't need to take care of that.
>>
>> Simplify the external API and handle it differently within the OPP core.
>>
>> This shouldn't result in any functional change.
> Hi, so this apparently breaks serial on Qualcomm platforms using
> "qcom,geni-debug-uart".. I'm seeing garbage on the console, likely
> meaning that ratesetting wasn't done.

+CC Bjorn, Dmitry

Probably also worth noting it only happens when an OPP table is present
in the device tree.

Konrad