linux-kernel - [PATCH] regulator: event: Ensure atomicity for sequence number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Thu,  4 Jan 2024 19:43:13 +0530
From: Naresh Solanki <naresh.solanki@...ements.com>
To: broonie@...nel.org,
	Liam Girdwood <lgirdwood@...il.com>
Cc: mazziesaccount@...il.com,
	Naresh Solanki <naresh.solanki@...ements.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] regulator: event: Ensure atomicity for sequence number

Previously, the sequence number in the regulator event subsystem was
updated without atomic operations, potentially leading to race
conditions. This commit addresses the issue by making the sequence
number atomic.

Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>
---
 drivers/regulator/event.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/event.c b/drivers/regulator/event.c
index 0ec58f306b38..ea3bd49544e8 100644
--- a/drivers/regulator/event.c
+++ b/drivers/regulator/event.c
@@ -8,10 +8,11 @@
 #include <regulator/regulator.h>
 #include <net/netlink.h>
 #include <net/genetlink.h>
+#include <linux/atomic.h>
 
 #include "regnl.h"
 
-static unsigned int reg_event_seqnum;
+static atomic_t reg_event_seqnum = ATOMIC_INIT(0);
 
 static const struct genl_multicast_group reg_event_mcgrps[] = {
 	{ .name = REG_GENL_MCAST_GROUP_NAME, },
@@ -43,9 +44,8 @@ int reg_generate_netlink_event(const char *reg_name, u64 event)
 		return -ENOMEM;
 
 	/* add the genetlink message header */
-	msg_header = genlmsg_put(skb, 0, reg_event_seqnum++,
-				 &reg_event_genl_family, 0,
-				 REG_GENL_CMD_EVENT);
+	msg_header = genlmsg_put(skb, 0, atomic_inc_return(&reg_event_seqnum),
+				 &reg_event_genl_family, 0, REG_GENL_CMD_EVENT);
 	if (!msg_header) {
 		nlmsg_free(skb);
 		return -ENOMEM;

base-commit: 67ba055dd7758c34f6e64c9d35132362c1e1f0b5
-- 
2.41.0