linux-kernel - Re: [PATCH] android: removed asm-generic/errno-base.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4655f620-e43f-4381-b3d4-c8d5555fd739@joelfernandes.org>
Date: Thu, 4 Jan 2024 11:08:29 -0500
From: Joel Fernandes <joel@...lfernandes.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Tanzir Hasan <tanzirh@...gle.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Arve Hjønnevåg <arve@...roid.com>,
 Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
 Christian Brauner <brauner@...nel.org>, Carlos Llamas <cmllamas@...gle.com>,
 Suren Baghdasaryan <surenb@...gle.com>
Cc: linux-kernel@...r.kernel.org, Nick Desaulniers <nnn@...gle.com>,
 Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] android: removed asm-generic/errno-base.h



On 1/4/2024 10:36 AM, Christophe JAILLET wrote:
> Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
>> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
>> will still build correctly. It is an asm-generic file which should be
>> avoided if possible.
>>
>> Suggested-by: Al Viro <viro@...iv.linux.org.uk>
>> Signed-off-by: Tanzir Hasan <tanzirh@...gle.com>
>> ---
>>   drivers/android/binderfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
>> index 1224ab7aa070..d04ff6029480 100644
>> --- a/drivers/android/binderfs.c
>> +++ b/drivers/android/binderfs.c
>> @@ -29,7 +29,7 @@
>>   #include <linux/uaccess.h>
>>   #include <linux/user_namespace.h>
>>   #include <linux/xarray.h>
>> -#include <uapi/asm-generic/errno-base.h>
>> +#include <linux/errno.h>
> 
> linux/errno.h is already included a few lines above.
> 

Good point! With that nit addressed:
Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>

Thanks.