linux-kernel - Re: linux-next: build warning after merge of the drm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frzdyrbg.fsf@intel.com>
Date: Thu, 04 Jan 2024 18:52:03 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>, Dave Airlie <airlied@...hat.com>
Cc: Linux Next Mailing List <linux-next@...r.kernel.org>, Andrzej Hajda
 <andrzej.hajda@...el.com>, DRI <dri-devel@...ts.freedesktop.org>, Linux
 Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the drm tree

On Wed, 03 Jan 2024, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> OK, the only thing I can find is that there are 2 intel_wakeref.h files
> that have different definitions for intel_wakeref_t:
>
> ./drivers/gpu/drm/i915/intel_wakeref.h:typedef unsigned long intel_wakeref_t;
> ./drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h:typedef bool intel_wakeref_t;
>
> and the two compilations above seem to use different include paths, but
> how the single character change causes that is beyond me.

There are a few things going on here, but the gist of it is that
intel_wakeref_t is supposed to be an opaque cookie, and printing its
value does not make sense, especially not when you can't be certain
which printf format should be used for it.

Fix at [1], thanks for the report.

BR,
Jani.


[1] https://patchwork.freedesktop.org/patch/msgid/20240104164600.783371-1-jani.nikula@intel.com


-- 
Jani Nikula, Intel