linux-kernel - Re: [PATCH v2 2/3] binder: Use of hlist_count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZZbrgYTkhp_EH6Ci@google.com>
Date: Thu, 4 Jan 2024 17:31:45 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Pierre Gondois <pierre.gondois@....com>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>, Coly Li <colyli@...e.de>,
	Kent Overstreet <kent.overstreet@...il.com>,
	Marco Elver <elver@...gle.com>, Kees Cook <keescook@...omium.org>,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-bcache@...r.kernel.org
Subject: Re: [PATCH v2 2/3] binder: Use of hlist_count_nodes()

On Thu, Jan 04, 2024 at 05:49:34PM +0100, Pierre Gondois wrote:
> Make use of the newly added hlist_count_nodes().
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
> ---
>  drivers/android/binder.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 92128aae2d06..f9ca4d58d825 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6077,9 +6077,7 @@ static void print_binder_node_nilocked(struct seq_file *m,
>  	struct binder_work *w;
>  	int count;
>  
> -	count = 0;
> -	hlist_for_each_entry(ref, &node->refs, node_entry)
> -		count++;
> +	count = hlist_count_nodes(&node->refs);
>  
>  	seq_printf(m, "  node %d: u%016llx c%016llx hs %d hw %d ls %d lw %d is %d iw %d tr %d",
>  		   node->debug_id, (u64)node->ptr, (u64)node->cookie,
> -- 
> 2.25.1
> 

Looks good to me!

Acked-by: Carlos Llamas <cmllamas@...gle.com>