linux-kernel - Re: [PATCH 2/4] platform/x86: wmi: Return immediately if an suitable WMI event is found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fc39362-c4fc-6088-4ec-d44ca6328252@linux.intel.com>
Date: Thu, 4 Jan 2024 20:13:53 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Armin Wolf <W_Armin@....de>
cc: Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] platform/x86: wmi: Return immediately if an suitable
 WMI event is found

On Wed, 3 Jan 2024, Armin Wolf wrote:

> Commit 58f6425eb92f ("WMI: Cater for multiple events with same GUID")
> allowed legacy WMI notify handlers to be installed for multiple WMI
> devices with the same GUID.
> However this is useless since the legacy GUID-based interface is
> blacklisted from seeing WMI devices with duplicated GUIDs.
> 
> Return immediately if a suitable WMI event is found in
> wmi_install/remove_notify_handler() since searching for other suitable
> events is pointless.
> 
> Tested on a Dell Inspiron 3505 and a Acer Aspire E1-731.
> 
> Signed-off-by: Armin Wolf <W_Armin@....de>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.