linux-kernel - RE: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB11269AA2B4A9372ABF78E5EEA86672@TYCPR01MB11269.jpnprd01.prod.outlook.com>
Date: Thu, 4 Jan 2024 19:08:54 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>, Support Opensource
	<support.opensource@...semi.com>
CC: "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs

Hi Dmitry Torokhov,

Thanks for the patch.

> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Sent: Thursday, December 21, 2023 3:09 AM
> To: Support Opensource <support.opensource@...semi.com>; Biju Das
> <biju.das.jz@...renesas.com>
> Cc: linux-input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs
> 
> There is nothing OF-specific in the driver, so switch from OF properties
> helpers to generic device helpers.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

> ---
>  drivers/input/misc/da9063_onkey.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/misc/da9063_onkey.c
> b/drivers/input/misc/da9063_onkey.c
> index a8b7f1cd0ec2..ce499c28a7b2 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -9,11 +9,12 @@
>  #include <linux/errno.h>
>  #include <linux/input.h>
>  #include <linux/interrupt.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_wakeirq.h>
> +#include <linux/property.h>
>  #include <linux/workqueue.h>
>  #include <linux/regmap.h>
> -#include <linux/of.h>
>  #include <linux/mfd/da9063/core.h>
>  #include <linux/mfd/da9063/registers.h>  #include
> <linux/mfd/da9062/core.h> @@ -199,8 +200,8 @@ static int
> da9063_onkey_probe(struct platform_device *pdev)
>  		return dev_err_probe(&pdev->dev, -ENXIO,
>  				     "Parent regmap unavailable.\n");
> 
> -	onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
> -						  "dlg,disable-key-power");
> +	onkey->key_power = !device_property_read_bool(&pdev->dev,
> +						      "dlg,disable-key-power");
> 
>  	onkey->input = devm_input_allocate_device(&pdev->dev);
>  	if (!onkey->input)
> --
> 2.43.0.195.gebba966016-goog
> 
> 
> --
> Dmitry