linux-kernel - RE: [PATCH] Input: da9063_onkey - avoid explicitly setting input's parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB1126942265F2B95741501A78286672@TYCPR01MB11269.jpnprd01.prod.outlook.com>
Date: Thu, 4 Jan 2024 19:09:48 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>, Support Opensource
	<support.opensource@...semi.com>
CC: "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Input: da9063_onkey - avoid explicitly setting input's
 parent

Hi Dmitry Torokhov,

Thanks for the patch.

> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Sent: Thursday, December 21, 2023 3:10 AM
> To: Support Opensource <support.opensource@...semi.com>; Biju Das
> <biju.das.jz@...renesas.com>
> Cc: linux-input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] Input: da9063_onkey - avoid explicitly setting input's
> parent
> 
> devm_input_allocate_device() already sets parent of the new input device,
> there's no need to set it up explicitly.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

Cheers,
Biju

> ---
>  drivers/input/misc/da9063_onkey.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/da9063_onkey.c
> b/drivers/input/misc/da9063_onkey.c
> index ce499c28a7b2..c338765e0ecd 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -211,7 +211,6 @@ static int da9063_onkey_probe(struct platform_device
> *pdev)
>  	snprintf(onkey->phys, sizeof(onkey->phys), "%s/input0",
>  		 onkey->config->name);
>  	onkey->input->phys = onkey->phys;
> -	onkey->input->dev.parent = &pdev->dev;
> 
>  	input_set_capability(onkey->input, EV_KEY, KEY_POWER);
> 
> --
> 2.43.0.195.gebba966016-goog
> 
> 
> --
> Dmitry