linux-kernel - Re: [PATCH] asm-generic: Fix 32 bit __generic_cmpxchg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9e16b15b-e715-43a3-915e-7f43fb4af935@app.fastmail.com>
Date: Fri, 05 Jan 2024 23:25:21 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Stuart Menefy" <stuart.menefy@...asip.com>, linux-kernel@...r.kernel.org
Cc: Linux-Arch <linux-arch@...r.kernel.org>,
 "David McKay" <david.mckay@...asip.com>
Subject: Re: [PATCH] asm-generic: Fix 32 bit __generic_cmpxchg_local

On Thu, Jan 4, 2024, at 10:40, Stuart Menefy wrote:
> From: David McKay <david.mckay@...asip.com>
>
> Commit 656e9007ef58 ("asm-generic: avoid __generic_cmpxchg_local
> warnings") introduced a typo that means the code is incorrect for 32 bit
> values. It will work fine for postive numbers, but will fail for
> negative numbers on a system where longs are 64 bit.
>
> Fixes: 656e9007ef58 ("asm-generic: avoid __generic_cmpxchg_local warnings")
> Signed-off-by: David McKay <david.mckay@...asip.com>
> Signed-off-by: Stuart Menefy <stuart.menefy@...asip.com>

Applied to the asm-generic tree, thanks a lot!

      arnd