linux-kernel - Re: [PATCH v7 17/23] sched: Initial sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCrFLfwsmVCSSH0u0WfWCJVy6hWsO8fB3K=n-Wh0awmbNw@mail.gmail.com>
Date: Thu, 4 Jan 2024 21:25:05 -0800
From: John Stultz <jstultz@...gle.com>
To: Metin Kaya <metin.kaya@....com>
Cc: LKML <linux-kernel@...r.kernel.org>, Joel Fernandes <joelaf@...gle.com>, 
	Qais Yousef <qyousef@...gle.com>, Ingo Molnar <mingo@...hat.com>, 
	Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, 
	Vincent Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Valentin Schneider <vschneid@...hat.com>, Steven Rostedt <rostedt@...dmis.org>, 
	Ben Segall <bsegall@...gle.com>, Zimuzo Ezeozue <zezeozue@...gle.com>, 
	Youssef Esmat <youssefesmat@...gle.com>, Mel Gorman <mgorman@...e.de>, 
	Daniel Bristot de Oliveira <bristot@...hat.com>, Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>, 
	Boqun Feng <boqun.feng@...il.com>, "Paul E. McKenney" <paulmck@...nel.org>, 
	Xuewen Yan <xuewen.yan94@...il.com>, K Prateek Nayak <kprateek.nayak@....com>, 
	Thomas Gleixner <tglx@...utronix.de>, kernel-team@...roid.com
Subject: Re: [PATCH v7 17/23] sched: Initial sched_football test implementation

On Thu, Dec 28, 2023 at 8:36 AM Metin Kaya <metin.kaya@....com> wrote:
> On 20/12/2023 12:18 am, John Stultz wrote:
> > +int crazy_fan_thread(void *)
> > +{
> > +     int count = 0;
> > +
> > +     atomic_inc(&players_ready);
> > +     while (!READ_ONCE(game_over)) {
> > +             if (kthread_should_stop())
> > +                     break;
> > +             schedule();
> > +             udelay(1000);
> > +             msleep(2);
> > +             count++;
>
> @count is only increased. Is it really necessary?

Nope. Just remnants of earlier debug code.

>
> * Please prepend a prefix to prints to ease capturing the module logs.

Done.

> * I think `rmmod test_sched_football` throws `Device or resource busy`
> error and fails to remove the module because of missing module_exit().

Yep. I'm skipping this for now, but I'll see about adding it later
after I figure out the changes I need to manufacture the problematic
load-balancing condition I'm worried about, as it doesn't seem to
appear on its own so far.

thanks
-john