linux-kernel - Re: [PATCH] Bluetooth: mgmt: Fix wrong param be used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a3a481b-db1f-4325-8ca7-03f2bc44b2a2@molgen.mpg.de>
Date: Fri, 5 Jan 2024 09:03:12 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Clancy Shang <clancy_shang@....com>
Cc: marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
 linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
 zhongjun.yu@...ctel.com, Clancy Shang <clancy.shang@...ctel.com>
Subject: Re: [PATCH] Bluetooth: mgmt: Fix wrong param be used

Dear Clancy,


Thank you for your patch.

Am 05.01.24 um 04:11 schrieb clancy_shang@....com:
> From: Clancy Shang <clancy.shang@...ctel.com>
> 
> bluez lib could not receive MGMT_EV_DEVICE_FLAGS_CHANGED notifications
> after sending MGMT_OP_SET_DEVICE_FLAGS

Please add a dot/period at the end of sentences.

Please extend the commit message to describe your fix, and why it fixes 
the problem.

> Signed-off-by: Clancy Shang <clancy.shang@...ctel.com>
> ---
>   net/bluetooth/mgmt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 9dd815b6603f..c74abdf3618f 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -5177,7 +5177,7 @@ static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
>   
>   done:
>   	if (status == MGMT_STATUS_SUCCESS)
> -		device_flags_changed(sk, hdev, &cp->addr.bdaddr, cp->addr.type,
> +		device_flags_changed(NULL, hdev, &cp->addr.bdaddr, cp->addr.type,
>   				     supported_flags, current_flags);
>   
>   	return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_DEVICE_FLAGS, status,


Kind regards,

Paul