linux-kernel - Re: [PATCH v7 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddf185b0-1a6e-cace-7dbe-ea48348491d0@gmx.de>
Date: Fri, 5 Jan 2024 11:44:27 +0100
From: Lino Sanfilippo <LinoSanfilippo@....de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Lino Sanfilippo <l.sanfilippo@...bus.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, u.kleine-koenig@...gutronix.de,
 shawnguo@...nel.org, s.hauer@...gutronix.de, mcoquelin.stm32@...il.com,
 alexandre.torgue@...s.st.com, cniedermaier@...electronics.com,
 hugo@...ovil.com, m.brock@...mierlo.com, LKML
 <linux-kernel@...r.kernel.org>, linux-serial <linux-serial@...r.kernel.org>,
 Lukas Wunner <lukas@...ner.de>, p.rosenberger@...bus.com,
 stable@...r.kernel.org
Subject: Re: [PATCH v7 1/7] serial: Do not hold the port lock when setting
 rx-during-tx GPIO

On 03.01.24 at 12:10, Ilpo Järvinen wrote:
> On Wed, 3 Jan 2024, Lino Sanfilippo wrote:
>

>> Also with commit c54d48543689 ("serial: stm32: Add support for rs485
>> RX_DURING_TX output GPIO") the SER_RS485_RX_DURING_TX flag is only set if a
>> rx-during-tx GPIO is _not_ available, which is wrong. Fix this, too.
>
> This doesn't explain why it's wrong and I could figure it out myself
> either.
>

Ugh, you are right. I confused some things here. This part of the patch is completely
wrong and the concerning code was correct as it was before. I will correct this patch
for v8.


Thanks,
Lino