linux-kernel - Re: [PATCH] usb: core: Make default authorization mode configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024010518-embattled-illusion-9a13@gregkh>
Date: Fri, 5 Jan 2024 13:06:33 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Niko Mauno <niko.mauno@...sala.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jaaskelainen Vesa VEJ <vesa.jaaskelainen@...sala.com>
Subject: Re: [PATCH] usb: core: Make default authorization mode configurable

On Fri, Jan 05, 2024 at 01:56:35PM +0200, Niko Mauno wrote:
> On 4.1.2024 18.41, Greg KH wrote:
> > On Thu, Jan 04, 2024 at 06:32:03PM +0200, niko.mauno@...sala.com wrote:
> ...
> > > +       The available values have the following meanings:
> > > +             -1 is authorized for all devices (leftover from wireless USB)
> > > +             0 is unauthorized for all devices
> > > +             1 is authorized for all devices
> > 
> > What's the difference now between -1 and 1?  We don't have wireless USB
> > anymore as that never turned into an actual product, so we shouldn't
> > reference it anymore, right?
> > 
> > We should get rid of the -1 option entirely, but keep the module option
> > and properly map it to '1'.
> > 
> > 
> > > +             2 is authorized for internal devices
> > 
> > Needs a "if you don't know what to select, please choose X" text here.
> 
> Thanks, submitted v2 which strives to address also these considerations.

Much better, thanks.  I'll look at them after 6.8-rc1 is out.

greg k-h