linux-kernel - Re: [PATCH] usb: typec: tipd: fix use of device-specific init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024010558-unhappy-scandal-b823@gregkh>
Date: Fri, 5 Jan 2024 13:53:09 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Roger Quadros <rogerq@...nel.org>,
	Javier Carrasco <javier.carrasco@...fvision.net>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: fix use of device-specific init
 function

On Fri, Jan 05, 2024 at 01:42:47PM +0100, Javier Carrasco wrote:
> On 05.01.24 13:36, Heikki Krogerus wrote:
> > On Thu, Jan 04, 2024 at 06:07:12PM +0100, Javier Carrasco wrote:
> >> The current implementation supports device-pecific callbacks for the
> >> init function with a function pointer. The patch that introduced this
> >> feature did not update one call to the tps25750 init function to turn it
> >> into a call with the new pointer in the resume function.
> >>
> >> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> > 
> > This was suggested by Roger, no?
> > 
> 
> Yes, it was. Thanks for the reminder.
> 
> Could the following trailer be added before applying?
> 
> Suggested-by: Roger Quadros <rogerq@...nel.org>

The tools automatically just added that now, thanks.

greg k-h