linux-kernel - Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jaybj2ra7cjsfazxcumpkaozthl245a6s4sdmjsrmvpuddb5ye@cntxrwommw4z>
Date: Fri, 5 Jan 2024 21:27:28 +0800
From: Coiby Xu <coxu@...hat.com>
To: Eric Snowberg <eric.snowberg@...cle.com>
Cc: "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>, 
	"itrymybest80@...tonmail.com" <itrymybest80@...tonmail.com>, Mimi Zohar <zohar@...ux.ibm.com>, 
	Dmitry Kasatkin <dmitry.kasatkin@...il.com>, Paul Moore <paul@...l-moore.com>, 
	James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, 
	"open list:SECURITY SUBSYSTEM" <linux-security-module@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] integrity: don't throw an error immediately when
 failed to add a cert to the .machine keyring

On Tue, Jan 02, 2024 at 05:33:53PM +0000, Eric Snowberg wrote:
>
>
>> On Dec 26, 2023, at 9:41 PM, Coiby Xu <coxu@...hat.com> wrote:
>>
>> Currently when the kernel fails to add a cert to the .machine keyring,
>> it will throw an error immediately in the function integrity_add_key.
>>
>> Since the kernel will try adding to the .platform keyring next or throw
>> an error (in the caller of integrity_add_key i.e. add_to_machine_keyring),
>> so there is no need to throw an error immediately in integrity_add_key.
>>
>> Reported-by: itrymybest80@...tonmail.com
>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2239331
>> Signed-off-by: Coiby Xu <coxu@...hat.com>
>
>Reviewed-by: Eric Snowberg <eric.snowberg@...cle.com>

Thank you for reviewing the patch!

-- 
Best regards,
Coiby