linux-kernel - Re:Re: [PATCH v6] serial: linflexuart: Remove redundant uart type assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ee52b724-799f-1be5-b455-8e82aba55ee2@linux.intel.com>
Date: Fri, 5 Jan 2024 16:48:17 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: lizhe <sensor1010@....com>
cc: Jiri Slaby <jirislaby@...nel.org>, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    linux-serial <linux-serial@...r.kernel.org>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re:Re: [PATCH v6] serial: linflexuart: Remove redundant uart type
 assignment

On Fri, 5 Jan 2024, lizhe wrote:

> HI，all
> 
>        How should I wirte these comments ? please help me, 
>        i am not sure how to properly write these comments, 
>        i want to merge this patch into the mainline
> 
> 
> 
> 
> 
> 
> At 2023-01-06 15:16:56, "Jiri Slaby" <jirislaby@...nel.org> wrote:
> >On 05. 01. 23, 18:04, 李哲 wrote:
> >> in linflex_config_port() the member variable type will be
> >> assigned again. see linflex_connfig_port()
> >
> >I wrote to v5:
> >Please use capitals when you start a sentence. And periods at the ends 
> >of them.
> >> Signed-off-by: 李哲 <sensor1010@....com>
> >
> >
> >> V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5d
> c891aef@...nel.org/
> >> V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536f
> be5f@...ux.intel.com/
> >> V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc
> 938f6b@...ux.intel.com/
> >> V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b41
> 8665784@...nel.org/
> >
> >This is not the proper way. PLease see:
> >https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-
> canonical-patch-format

For this you need to spell out the changes you made between versions.

E.g.,

v6:
- Used Chinese letters for From and Signed-off-by


-- 
 i.