linux-kernel - Re: [PATCH] drm/xe/selftests: Fix an error pointer dereference bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZZhlp4NXToubg+PJ@DUT025-TGLU.fm.intel.com>
Date: Fri, 5 Jan 2024 20:25:11 +0000
From: Matthew Brost <matthew.brost@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>, Lucas De Marchi
	<lucas.demarchi@...el.com>, Oded Gabbay <ogabbay@...nel.org>, Thomas
 Hellström <thomas.hellstrom@...ux.intel.com>, "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Rodrigo Vivi
	<rodrigo.vivi@...el.com>, Matthew Auld <matthew.auld@...el.com>, Nirmoy Das
	<nirmoy.das@...el.com>, Matt Roper <matthew.d.roper@...el.com>, "Pallavi
 Mishra" <pallavi.mishra@...el.com>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] drm/xe/selftests: Fix an error pointer dereference bug

On Fri, Jan 05, 2024 at 03:20:35PM +0300, Dan Carpenter wrote:
> Check if "bo" is an error pointer before calling xe_bo_lock() on it.
> 
> Fixes: d6abc18d6693 ("drm/xe/xe2: Modify xe_bo_test for system memory")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Matthew Brost <matthew.brost@...el.com>

> ---
>  drivers/gpu/drm/xe/tests/xe_bo.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_bo.c b/drivers/gpu/drm/xe/tests/xe_bo.c
> index 412b2e7ce40c..3436fd9cf2b2 100644
> --- a/drivers/gpu/drm/xe/tests/xe_bo.c
> +++ b/drivers/gpu/drm/xe/tests/xe_bo.c
> @@ -125,14 +125,13 @@ static void ccs_test_run_tile(struct xe_device *xe, struct xe_tile *tile,
>  
>  	bo = xe_bo_create_user(xe, NULL, NULL, SZ_1M, DRM_XE_GEM_CPU_CACHING_WC,
>  			       ttm_bo_type_device, bo_flags);
> -
> -	xe_bo_lock(bo, false);
> -
>  	if (IS_ERR(bo)) {
>  		KUNIT_FAIL(test, "Failed to create bo.\n");
>  		return;
>  	}
>  
> +	xe_bo_lock(bo, false);
> +
>  	kunit_info(test, "Verifying that CCS data is cleared on creation.\n");
>  	ret = ccs_test_migrate(tile, bo, false, 0ULL, 0xdeadbeefdeadbeefULL,
>  			       test);
> -- 
> 2.42.0
>