linux-kernel - arch/arm64/kvm/sys_regs.c:2402: warning: Function parameter or member 'params' not described in 'kvm_handle_cp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Sat, 6 Jan 2024 21:14:09 +0800
From: kernel test robot <lkp@...el.com>
To: Oliver Upton <oupton@...gle.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Marc Zyngier <maz@...nel.org>, Reiji Watanabe <reijiw@...gle.com>
Subject: arch/arm64/kvm/sys_regs.c:2402: warning: Function parameter or
 member 'params' not described in 'kvm_handle_cp_32'

Hi Oliver,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   95c8a35f1c017327eab3b6a2ff5c04255737c856
commit: e65197666773f39e4378161925e5a1c7771cff29 KVM: arm64: Wire up CP15 feature registers to their AArch64 equivalents
date:   1 year, 8 months ago
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240106/202401062105.Xv4LmwCQ-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240106/202401062105.Xv4LmwCQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401062105.Xv4LmwCQ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/arm64/kvm/sys_regs.c:2305: warning: Function parameter or member 'global' not described in 'kvm_handle_cp_64'
   arch/arm64/kvm/sys_regs.c:2305: warning: Function parameter or member 'nr_global' not described in 'kvm_handle_cp_64'
   arch/arm64/kvm/sys_regs.c:2305: warning: Excess function parameter 'run' description in 'kvm_handle_cp_64'
>> arch/arm64/kvm/sys_regs.c:2402: warning: Function parameter or member 'params' not described in 'kvm_handle_cp_32'
   arch/arm64/kvm/sys_regs.c:2402: warning: Function parameter or member 'global' not described in 'kvm_handle_cp_32'
   arch/arm64/kvm/sys_regs.c:2402: warning: Function parameter or member 'nr_global' not described in 'kvm_handle_cp_32'
   arch/arm64/kvm/sys_regs.c:2402: warning: Excess function parameter 'run' description in 'kvm_handle_cp_32'


vim +2402 arch/arm64/kvm/sys_regs.c

e65197666773f3 Oliver Upton 2022-05-03  2392  
62a89c44954f09 Marc Zyngier 2013-02-07  2393  /**
7769db905bd2df Shannon Zhao 2016-01-13  2394   * kvm_handle_cp_32 -- handles a mrc/mcr trap on a guest CP14/CP15 access
62a89c44954f09 Marc Zyngier 2013-02-07  2395   * @vcpu: The VCPU pointer
62a89c44954f09 Marc Zyngier 2013-02-07  2396   * @run:  The kvm_run struct
62a89c44954f09 Marc Zyngier 2013-02-07  2397   */
72564016aae45f Marc Zyngier 2014-04-24  2398  static int kvm_handle_cp_32(struct kvm_vcpu *vcpu,
e65197666773f3 Oliver Upton 2022-05-03  2399  			    struct sys_reg_params *params,
72564016aae45f Marc Zyngier 2014-04-24  2400  			    const struct sys_reg_desc *global,
dcaffa7bf91157 James Morse  2020-06-22  2401  			    size_t nr_global)
62a89c44954f09 Marc Zyngier 2013-02-07 @2402  {
c667186f1c01ca Marc Zyngier 2017-04-27  2403  	int Rt  = kvm_vcpu_sys_get_rt(vcpu);
62a89c44954f09 Marc Zyngier 2013-02-07  2404  
e65197666773f3 Oliver Upton 2022-05-03  2405  	params->regval = vcpu_get_reg(vcpu, Rt);
62a89c44954f09 Marc Zyngier 2013-02-07  2406  
e65197666773f3 Oliver Upton 2022-05-03  2407  	if (emulate_cp(vcpu, params, global, nr_global)) {
e65197666773f3 Oliver Upton 2022-05-03  2408  		if (!params->is_write)
e65197666773f3 Oliver Upton 2022-05-03  2409  			vcpu_set_reg(vcpu, Rt, params->regval);
72564016aae45f Marc Zyngier 2014-04-24  2410  		return 1;
2ec5be3dbfdcb6 Pavel Fedin  2015-12-04  2411  	}
72564016aae45f Marc Zyngier 2014-04-24  2412  
e65197666773f3 Oliver Upton 2022-05-03  2413  	unhandled_cp_access(vcpu, params);
62a89c44954f09 Marc Zyngier 2013-02-07  2414  	return 1;
62a89c44954f09 Marc Zyngier 2013-02-07  2415  }
62a89c44954f09 Marc Zyngier 2013-02-07  2416  

:::::: The code at line 2402 was first introduced by commit
:::::: 62a89c44954f09072bf07a714c8f68bda14ab87e arm64: KVM: 32bit handling of coprocessor traps

:::::: TO: Marc Zyngier <marc.zyngier@....com>
:::::: CC: Marc Zyngier <marc.zyngier@....com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki