linux-kernel - [PATCH v2] soc: pxa: ssp: fix casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240106-pxa-ssp-v2-1-69ac9f028bba@skole.hr>
Date: Sat, 06 Jan 2024 15:11:33 +0100
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Arnd Bergmann <arnd@...db.de>, 
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
 Robert Jarzmik <robert.jarzmik@...e.fr>
Cc: Lubomir Rintel <lkundrak@...sk>, zhang songyi <zhang.songyi@....com.cn>, 
 soc@...nel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, 
 Duje Mihanović <duje.mihanovic@...le.hr>
Subject: [PATCH v2] soc: pxa: ssp: fix casts

On ARM64 platforms, id->data is a 64-bit value and casting it to a
32-bit integer causes build errors. Cast it to uintptr_t instead.

The id->driver_data cast is unnecessary, so drop it.

Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
---
This patch is necessary for my Marvell PXA1908 series to compile successfully
with allyesconfig:
https://lore.kernel.org/all/20231102-pxa1908-lkml-v7-0-cabb1a0cb52b@skole.hr/

Changes in v2:
- Change first cast to (uintptr_t)
- Drop second cast
- Link to v1: https://lore.kernel.org/20240103210604.16877-1-duje.mihanovic@skole.hr
---
 drivers/soc/pxa/ssp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c
index a1e8a07f7275..7af04e8b8163 100644
--- a/drivers/soc/pxa/ssp.c
+++ b/drivers/soc/pxa/ssp.c
@@ -152,11 +152,11 @@ static int pxa_ssp_probe(struct platform_device *pdev)
 	if (dev->of_node) {
 		const struct of_device_id *id =
 			of_match_device(of_match_ptr(pxa_ssp_of_ids), dev);
-		ssp->type = (int) id->data;
+		ssp->type = (uintptr_t) id->data;
 	} else {
 		const struct platform_device_id *id =
 			platform_get_device_id(pdev);
-		ssp->type = (int) id->driver_data;
+		ssp->type = id->driver_data;
 
 		/* PXA2xx/3xx SSP ports starts from 1 and the internal pdev->id
 		 * starts from 0, do a translation here

---
base-commit: 610a9b8f49fbcf1100716370d3b5f6f884a2835a
change-id: 20240106-pxa-ssp-522745d42418

Best regards,
-- 
Duje Mihanović <duje.mihanovic@...le.hr>