linux-kernel - Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZZl5rBPOKwvxZAAx@sunspire>
Date: Sat, 6 Jan 2024 18:02:52 +0200
From: Petre Rodan <petre.rodan@...dimension.ro>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andreas Klinger <ak@...klinger.de>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Angel Iglesias <ang.iglesiasg@...il.com>,
	Matti Vaittinen <mazziesaccount@...il.com>
Subject: Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver


hello Andy,

On Sat, Jan 06, 2024 at 05:30:21PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 29, 2023 at 11:24:38AM +0200, Petre Rodan wrote:
> > Add SPI component of the driver.
> 
> > Tested with mprls0015pa0000sa in spi mode on BeagleBone Black on
> > slightly patched 6.7.0-rc6 mainline.
> 
> > Tested with mprls0025pa in i2c mode on BeagleBone Black with togreg
> > branch on
> > git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> > (tag: iio-for-6.8a)
> 
> I believe these paragraphs can be moved to the patch submission comments from
> the commit message...
> 
> > Tested-by: Andreas Klinger <ak@...klinger.de>
> > Signed-off-by: Petre Rodan <petre.rodan@...dimension.ro>
> > ---
> > v2 -> v3 removed iio.h include line
> 
> ...somewhere here.
> 
> ...
> 
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/module.h>
> > +#include <linux/spi/spi.h>
> > +#include <linux/stddef.h>
> 
> Basically here we need additionally these ones:
> 
> device.h
> errno.h
> types.h

ok, I'll add errno.h. the other two are in the shared .h file.

cheers,
peter

> (I haven't checked i2c counterpart for the similarities).
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
petre rodan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)