linux-kernel - [PATCH] net: sfp: add fixup for tplink 2.5gbase-t rj45 modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240106-tplink-25gbaset-sfp-fixup-v1-1-8d26696bd2f4@solid-run.com>
Date: Sat, 06 Jan 2024 17:29:56 +0100
From: Josua Mayer <josua@...id-run.com>
To: Russell King <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>, 
 Heiner Kallweit <hkallweit1@...il.com>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Josua Mayer <josua@...id-run.com>
Subject: [PATCH] net: sfp: add fixup for tplink 2.5gbase-t rj45 modules

TP-Link TL-SM410U modules are single-rate 2.5GBase-T RJ45 SFP modules.
The EEPROM data is lying about connector and extended cc,
reporting 25Gbps fiber.

Add fixup for these specific modules forcing RJ45 @ 2.5Gbase-T.

For reference original eeprom data dump from ethtool:

Identifier                : 0x03 (SFP)
Extended identifier       : 0x04 (GBIC/SFP defined by 2-wire interface ID)
Connector                 : 0x07 (LC)
Transceiver codes         : 0x00 0x00 0x00 0x00 0x00 0x00 0x40 0x00 0x00
Transceiver type          : FC: Twisted Pair (TP)
Encoding                  : 0x01 (8B/10B)
BR, Nominal               : 3100MBd
Rate identifier           : 0x00 (unspecified)
Length (SMF,km)           : 0km
Length (SMF)              : 0m
Length (50um)             : 0m
Length (62.5um)           : 0m
Length (Copper)           : 0m
Length (OM3)              : 0m
Laser wavelength          : 0nm
Vendor name               : TP-LINK
Vendor OUI                : 00:00:00
Vendor PN                 : TL-SM410U
Vendor rev                : 1.0
Option values             : 0x00 0x18
Option                    : TX_FAULT implemented
Option                    : TX_DISABLE implemented
BR margin, max            : 0%
BR margin, min            : 0%
Vendor SN                 : 12154J6001608
Date code                 : 210611

Signed-off-by: Josua Mayer <josua@...id-run.com>
---
 drivers/net/phy/sfp.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 5468bd209fab..a5bb9d569381 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -340,6 +340,12 @@ static const struct of_device_id sfp_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, sfp_of_match);
 
+static void sfp_fixup_2500baset(struct sfp *sfp)
+{
+	sfp->id.base.connector = SFF8024_CONNECTOR_RJ45;
+	sfp->id.base.extended_cc = SFF8024_ECC_2_5GBASE_T;
+}
+
 static void sfp_fixup_long_startup(struct sfp *sfp)
 {
 	sfp->module_t_start_up = T_START_UP_BAD_GPON;
@@ -503,6 +509,10 @@ static const struct sfp_quirk sfp_quirks[] = {
 	SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
 	SFP_QUIRK_F("Turris", "RTSFP-10", sfp_fixup_rollball),
 	SFP_QUIRK_F("Turris", "RTSFP-10G", sfp_fixup_rollball),
+
+	// tp-link 2.5Gbase-T modules wrongly report 25Gbps fiber connector
+	// in their EEPROM
+	SFP_QUIRK_F("TP-LINK", "TL-SM410U", sfp_fixup_2500baset),
 };
 
 static size_t sfp_strlen(const char *str, size_t maxlen)

---
base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
change-id: 20240106-tplink-25gbaset-sfp-fixup-0eca2f8f7530

Sincerely,
-- 
Josua Mayer <josua@...id-run.com>