linux-kernel - Re: [PATCH] dt-bindings: pxa-pwm: Convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f886744-e6da-4412-8876-306ba4210da0@linaro.org>
Date: Sat, 6 Jan 2024 18:01:58 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Duje Mihanović <duje.mihanovic@...le.hr>,
 Thierry Reding <thierry.reding@...il.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: pxa-pwm: Convert to YAML

On 05/01/2024 23:50, Duje Mihanović wrote:
> Convert the PXA PWM binding file from TXT to YAML.
> 
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-pxa.yaml | 51 ++++++++++++++++++++++
>  Documentation/devicetree/bindings/pwm/pxa-pwm.txt  | 30 -------------
>  2 files changed, 51 insertions(+), 30 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-pxa.yaml b/Documentation/devicetree/bindings/pwm/pwm-pxa.yaml
> new file mode 100644
> index 000000000000..fb20e4e1daa8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-pxa.yaml

Please keep new style of naming, so:
marvell,pxa-pwm.yaml

> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/pwm-pxa.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA PWM
> +
> +maintainers:
> +  - Duje Mihanović <duje.mihanovic@...le.hr>
> +
> +allOf:
> +  - $ref: pwm.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - marvell,pxa250-pwm
> +      - marvell,pxa270-pwm
> +      - marvell,pxa168-pwm
> +      - marvell,pxa910-pwm
> +
> +  reg:
> +    # Length should be 0x10
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    # Used for specifying the period length in nanoseconds
> +    const: 1
> +
> +  clocks:
> +    maxItems: 1

These were not in the original binding. Please mention briefly such
change in commit msg.


Best regards,
Krzysztof