linux-kernel - Re: [PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier to unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34121d01-34dd-4c29-b31e-91f3e8ea15bc@alu.unizg.hr>
Date: Sun, 7 Jan 2024 17:21:00 +0100
From: Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
To: Mark Brown <broonie@...nel.org>
Cc: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 linux-sound@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier
 to unsigned int

On 07. 01. 2024. 16:33, Mark Brown wrote:
> On Sun, Jan 07, 2024 at 04:12:20PM +0100, Mirsad Todorovac wrote:
> 
>> mixer-test.c:350:80: warning: format ‘%ld’ expects argument of type ‘long int’, \
>> 			      but argument 5 has type ‘unsigned int’ [-Wformat=]
> 
> If this is the issue then...
> 
>> -			ksft_print_msg("%s.%d value %ld more than item count %ld\n",
>> +			ksft_print_msg("%s.%d value %ld more than item count %d\n",
>>  				       ctl->name, index, int_val,
>>  				       snd_ctl_elem_info_get_items(ctl->info));
> 
> ...why are we not using an unsigned format specifier here?  I am very
> suprised this doesn't continue to warn.

I double-checked and there is no warning, but I will fix it as you
suggested.

> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

I am just looking at the `git log --oneline tools/testing/selftests/alsa`
and I can't seem to get inspiration.

I guess I can keep the Acked-by tags. Will the patchwork find the tag in
the v1 patch set?

Sorry for the lag in [PATCH v1 4/4]. I thought I pressed submit, but I
obviously did not.

Thanks,
Mirsad

-- 
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union

"I see something approaching fast ... Will it be friends with me?"