linux-kernel - Re: [PATCH] squashfs: Improve error handling in squashfs_decompressor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <522978349.868758.1704653130312@eu1.myprofessionalmail.com>
Date: Sun, 7 Jan 2024 18:45:30 +0000 (GMT)
From: Phillip Lougher <phillip@...ashfs.org.uk>
To: Markus Elfring <Markus.Elfring@....de>
Cc: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] squashfs: Improve error handling in
 squashfs_decompressor_create()

> On 30/12/2023 09:55 GMT Markus Elfring <markus.elfring@....de> wrote:
> 
>  
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 29 Dec 2023 21:30:26 +0100
> 
> The kfree() function was called in two cases by
> the squashfs_decompressor_create() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
> 
> * Thus return directly after a call of the function “kzalloc” failed
>   at the beginning.
> 
> * Use another label.
> 
> * Move an error code assignment into an if branch.
> 
> * Delete an initialisation (for the variable “decomp_strm”)
>   which became unnecessary with this refactoring.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

As mentioned in this thread (and many others)

https://lore.kernel.org/all/20240104204032.GN31813@kernel.org/

calling Kfree with a NULL pointer is perfectly valid.

So like most others I'm going to ignore this patch.

Cheers

Phillip