linux-kernel - Re: [PATCH][next] iio: invensense: remove redundant initialization of variable period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 7 Jan 2024 20:18:03 +0000
From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
To: Jonathan Cameron <jic23@...nel.org>,
        Colin Ian King
	<colin.i.king@...il.com>
CC: Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko
	<andy.shevchenko@...il.com>,
        "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] iio: invensense: remove redundant initialization of
 variable period

Hello Colin & Jonathan,

this is OK for me, thanks for the patch.
The initialization is certainly coming from first development and is not needed.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>

Thanks,
JB

From: Jonathan Cameron <jic23@...nel.org>
Sent: Sunday, January 7, 2024 17:07
To: Colin Ian King <colin.i.king@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>; Andy Shevchenko <andy.shevchenko@...il.com>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; kernel-janitors@...r.kernel.org <kernel-janitors@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] iio: invensense: remove redundant initialization of variable period 
 
On Sat, 6 Jan 2024 15: 32: 02 +0000 Colin Ian King <colin. i. king@ gmail. com> wrote: > The variable period is being initialized with a value that is never > read, it is being re-assigned a new value later on before it is read. > 
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender 
This message came from outside your organization. 
 
ZjQcmQRYFpfptBannerEnd
On Sat,  6 Jan 2024 15:32:02 +0000
Colin Ian King <colin.i.king@...il.com> wrote:

> The variable period is being initialized with a value that is never
> read, it is being re-assigned a new value later on before it is read.
> The initialization is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> Value stored to 'period' during its initialization is never
> read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Hi Colin,

I definitely want input from someone who can test this.
There is direct use of ts->period as well as the local
variable that is indeed overwritten as you've noted.
Feels like naming needs some work and perhaps reduce the scope of
the period local variable so it's obvious it was only intended
for more local use than it currently looks like.

Thanks,

Jonathan

> ---
>  drivers/iio/common/inv_sensors/inv_sensors_timestamp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c b/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c
> index 03823ee57f59..3b0f9598a7c7 100644
> --- a/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c
> +++ b/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c
> @@ -126,7 +126,7 @@ void inv_sensors_timestamp_interrupt(struct inv_sensors_timestamp *ts,
>  	struct inv_sensors_timestamp_interval *it;
>  	int64_t delta, interval;
>  	const uint32_t fifo_mult = fifo_period / ts->chip.clock_period;
> -	uint32_t period = ts->period;
> +	uint32_t period;
>  	bool valid = false;
>  
>  	if (fifo_nb == 0)